Skip to content

Add support for timeout options #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sdebruyn merged 2 commits into from
May 21, 2023
Merged

Add support for timeout options #395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b94291
add timeout parameters
sdebruyn May 21, 2023
772a14a
set correct defaults
sdebruyn May 21, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions dbt/adapters/sqlserver/sql_server_connection_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,9 @@ def connect():
con_str_concat,
attrs_before=attrs_before,
autocommit=True,
timeout=credentials.login_timeout,
)
handle.timeout = credentials.query_timeout
logger.debug(f"Connected to db: {credentials.database}")
return handle

Expand Down
4 changes: 4 additions & 0 deletions dbt/adapters/sqlserver/sql_server_credentials.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ class SQLServerCredentials(Credentials):
trust_cert: Optional[bool] = False # default value in MS ODBC Driver 18 as well
retries: int = 1
schema_authorization: Optional[str] = None
login_timeout: Optional[int] = 0
query_timeout: Optional[int] = 0

_ALIASES = {
"user": "UID",
Expand Down Expand Up @@ -58,6 +60,8 @@ def _connection_keys(self):
"encrypt",
"trust_cert",
"retries",
"login_timeout",
"query_timeout",
)

@property
Expand Down