Skip to content

Conversation

@davidkopp
Copy link
Owner

@davidkopp davidkopp commented Dec 27, 2023

Breaking changes:

  • Path provided in repo.conf through GH_REPO has changed from relative path to an absolute path and it was renamed to GIT_REPO_PATH. Example: GIT_REPO_PATH=~/storage/shared/git/notes

Changes:

  • support for multi-repo setup
  • enhance setup scripts to make the setup more user friendly
@davidkopp davidkopp mentioned this pull request Dec 27, 2023
@davidkopp davidkopp marked this pull request as ready for review December 28, 2023 20:14
@davidkopp davidkopp changed the title Support single and multi repo setup Support single and multi repo setup & make setup more user-friendly Dec 28, 2023
@davidkopp davidkopp merged commit ad925f9 into main Dec 28, 2023
@davidkopp davidkopp deleted the support-single-and-multi-repo-setup branch December 28, 2023 20:16
@davidkopp
Copy link
Owner Author

@abatkin With this PR I have changed the setup scripts significantly. I would be happy to know if the scripts still cover your use case or if there are additional changes necessary.

Copy link
Contributor

@abatkin abatkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would work as-is (except the -d check) and I will try it out soon. I also left some other comments that might simplify setup (and make it clearer that in multi-repo setups, repo.conf should not be present, since otherwise you'll end up with an unused copy with whatever values happen to be present after the final invocation of setup-git-repo.sh).

}

cd $HOME/storage/shared/$GH_REPO
echo -e "Setup Git repository\n"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prompting the user is interesting. If you didn't want to do that, another way to do it would be to check if repo.conf exists, and if it does, blindly use that. If it does not exist, ensure that the user passes in a path to a git repository (and optionally a branch name) and then trust that the user will also be passing in the path to Tasker, since no repo.conf file exists.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this also prompts the user so that the script can clone the repository if the user hasn't already done it. That's neat. Maybe if the repository directory doesn't exist, that's when you can prompt them?

@davidkopp davidkopp restored the support-single-and-multi-repo-setup branch December 29, 2023 07:32
@davidkopp davidkopp mentioned this pull request Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants