Skip to content
This repository was archived by the owner on Nov 25, 2021. It is now read-only.

Conversation

sluger
Copy link

@sluger sluger commented Apr 18, 2019

test with https://github.com/datavisyn/chartjs-chart-box-and-violin-plot/blob/sluger/39_fix_violin/samples/violinSingle.html

it should not break and crash the browser again
the single data point can't be drawn as there is no scale range for a single data point either

@sluger sluger requested a review from thinkh April 18, 2019 09:22
Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The browser does not crash in my tests.

@thinkh thinkh merged commit c1daa9b into develop Apr 18, 2019
@thinkh thinkh deleted the sluger/39_fix_violin branch April 18, 2019 10:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
2 participants