This repository was archived by the owner on Nov 25, 2021. It is now read-only.
Sluger/37 tooltips decimals #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
added 2 commits April 15, 2019 18:21
thinkh suggested changes Apr 16, 2019
src/controllers/base.js Outdated
| | ||
| export function toFixed(value) { | ||
| const decimals = this._chart.config.options.tooltipDecimals; // inject number of decimals from config | ||
| if (!decimals || typeof decimals !== 'number' || decimals < 0) { |
There was a problem hiding this comment.
This doesn't work as expected. !decimals will also be true for tooltipDecimals: 0 and return the full value. As developer I would expect that the function returns an integer.
The fix would be explicitly checking for null and undefined:
if (decimals === null || decimals === undefined || typeof decimals !== 'number' || decimals < 0) {There was a problem hiding this comment.
due to coercion decimals == null will check for both null and undefined
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
provide option to limit number of decimal digits
Related issue: #37