ref: Rename EdgeExtractor to LinkExtractor #516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This more closely matches how these operate. For each node we extract "links" (roughly, ports) indicating incoming/outgoing connections they should have. Edges are created while traversing based on the links. A node with an outgoing link has edges to nodes with matching incoming links. Also adds tests for the HTML link extractor.
| Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
bjchambers commented Jun 25, 2024
libs/langchain/ragstack_langchain/graph_store/extractors/link_extractor.py Outdated Show resolved Hide resolved
bjchambers commented Jun 25, 2024
cbornet reviewed Jun 26, 2024
libs/langchain/ragstack_langchain/graph_store/extractors/link_extractor.py Outdated Show resolved Hide resolved
cbornet approved these changes Jun 26, 2024
libs/langchain/ragstack_langchain/graph_store/extractors/html_link_extractor.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This more closely matches how these operate. For each node we extract "links" (roughly, ports) indicating incoming/outgoing connections they should have.
Edges are created while traversing based on the links. A node with an outgoing link has edges to nodes with matching incoming links.
Also adds tests for the HTML link extractor.