feat: Use tags exclusively for edge creation #471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This enables edge extractors to be implemented as document transformers configuring the metadata, rather than needing to interact with the underlying storage.
| Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
bjchambers commented Jun 10, 2024
kerinin approved these changes Jun 10, 2024
libs/knowledge-store/ragstack_knowledge_store/html_link_edge_extractor.py Outdated Show resolved Hide resolved
libs/knowledge-store/ragstack_knowledge_store/html_link_edge_extractor.py Show resolved Hide resolved
NadirJ approved these changes Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This enables edge extractors to be implemented as
document transformers configuring the metadata,
rather than needing to interact with the
underlying storage.