Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

cli: output diff as jsonl, stats as json #90

Merged
merged 3 commits into from
Jun 22, 2022
Merged

cli: output diff as jsonl, stats as json #90

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f09a866
cli: output diff as jsonl, stats as json
sirupsen Jun 21, 2022
94d1419
cli: add --json for stats, table1 + table2 counts
sirupsen Jun 21, 2022
37b47a0
cli: only json from standard diff with --json
sirupsen Jun 22, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions data_diff/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import sys
import time
import json
import logging
from itertools import islice

Expand Down Expand Up @@ -146,15 +147,24 @@ def main(
unique_diff_count = len({i[0] for _, i in diff})
table1_count = differ.stats.get("table1_count")
percent = 100 * unique_diff_count / (table1_count or 1)
print(f"Diff-Total: {len(diff)} changed rows out of {table1_count}")
print(f"Diff-Percent: {percent:.4f}%")
plus = len([1 for op, _ in diff if op == "+"])
minus = len([1 for op, _ in diff if op == "-"])
print(f"Diff-Split: +{plus} -{minus}")

count = differ.stats["table_count"]
diff = {
"different_rows": len(diff),
"different_percent": percent,
"different_+": plus,
"different_-": minus,
"total": count,
}

print(json.dumps(diff, indent=2))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is a bit less pretty, but I think this is most suitable as a tool that we want people to plug into all kinds of ecosystems.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default output should be easy to read for humans

We can have a --json switch for JSON output.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's OK with me... You OK with jsonl by default for the differences below though? I think it's just as readable, and then we don't have to maintain two formats.
else:
for op, key in diff_iter:
color = COLOR_SCHEME[op]
rich.print(f"[{color}]{op} {key!r}[/{color}]")
jsonl = json.dumps([op, list(key)])
rich.print(f"[{color}]{jsonl}[/{color}]")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanShot 2022-06-21 at 13 50 46@2x
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also depend on json output.

Though I do like ["a", "b"] better than the tuple.
Copy link
Contributor Author

@sirupsen sirupsen Jun 21, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just default to JSON then. I don't see why we'd need two formats here when it's so readable. Frankly, I do also disagree with you on the other one. Less maintenance to just have JSON
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

VS

image

You can try to argue they are "just as readable" but there is no way you will convince me.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Produced with text = f"{op} {', '.join(columns)}")
sys.stdout.flush()

end = time.time()
Expand Down
8 changes: 7 additions & 1 deletion data_diff/diff_tables.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,6 +381,12 @@ def _bisect_and_diff_tables(self, table1, table2, level=0, max_rows=None):
if max_rows < self.bisection_threshold:
rows1, rows2 = self._threaded_call("get_values", [table1, table2])
diff = list(diff_sets(rows1, rows2))

# This happens when the initial bisection threshold is larger than
# the table itself.
if level == 0 and not self.stats.get("table_count", False):
self.stats["table_count"] = self.stats.get("table_count", 0) + max(len(rows1), len(rows2))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes #68

When the count is lower than the bisection threshold on the initial segment, the table count is never set.

logger.info(". " * level + f"Diff found {len(diff)} different rows.")
self.stats["rows_downloaded"] = self.stats.get("rows_downloaded", 0) + max(len(rows1), len(rows2))
yield from diff
Expand Down Expand Up @@ -420,7 +426,7 @@ def _diff_tables(self, table1, table2, level=0, segment_index=None, segment_coun
return

if level == 1:
self.stats["table1_count"] = self.stats.get("table1_count", 0) + count1
self.stats["table_count"] = self.stats.get("table_count", 0) + max(count1, count2)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems a bit more expected it's the max
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should count both tables?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean independently? And then max them in the CLI? Sure, I don't really care since it's the only user. I guess since it's exposed via the API we can do that
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

if checksum1 != checksum2:
yield from self._bisect_and_diff_tables(table1, table2, level=level, max_rows=max(count1, count2))
Expand Down