This repository was archived by the owner on May 17, 2024. It is now read-only.
Fix precision recognition #823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
vvkh force-pushed the fix-numeric-precision-recognition-bq-pg branch from 397cc0d to c13e21b Compare vvkh force-pushed the fix-numeric-precision-recognition-bq-pg branch from 36cb51d to 6a18838 Compare vvkh force-pushed the fix-numeric-precision-recognition-bq-pg branch from 7c0ab72 to 3ce1832 Compare 
vvkh force-pushed the fix-numeric-precision-recognition-bq-pg branch from e25f45c to 781d2ea Compare 
dlawin reviewed Jan 3, 2024
dlawin approved these changes Jan 3, 2024
nolar reviewed Jan 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
In Postgres, if type is specified as
NUMERIC(no scale/precision parameters), the effective scale is 16383 (docs).In BigQuery, the effective scale in this case is 9 (community forum).