Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

[to#811]Fix special characters in PG url and Mysql connection reconnect #812

Merged
merged 8 commits into from
Dec 29, 2023
Merged

[to#811]Fix special characters in PG url and Mysql connection reconnect #812

merged 8 commits into from
Dec 29, 2023

Conversation

idling11
Copy link
Contributor

@idling11 idling11 commented Dec 26, 2023 •
edited by sungchun12
Loading

resolves #811

  1. fix special characters in PG url password
  2. fix mysql connection not available after a long idle time
@idling11 idling11 mentioned this pull request Dec 26, 2023
Closed
@idling11 idling11 changed the title [to#811]Fix special characters in PG and Mysql connection reconnect [to#811]Fix special characters in PG url and Mysql connection reconnect Dec 26, 2023
@sungchun12 sungchun12 self-assigned this Dec 26, 2023
@sungchun12 sungchun12 self-requested a review December 26, 2023 22:25
@sungchun12 sungchun12 assigned idling11 and unassigned sungchun12 Dec 26, 2023
@sungchun12 sungchun12 added the bug Something isn't working label Dec 26, 2023
sungchun12
sungchun12 suggested changes Dec 26, 2023
View reviewed changes
@sungchun12
Copy link
Contributor

Working on a fix for the ruff formatter.
@sungchun12 sungchun12 mentioned this pull request Dec 27, 2023
Merged
sungchun12
sungchun12 reviewed Dec 28, 2023
View reviewed changes
sungchun12
sungchun12 previously approved these changes Dec 28, 2023
View reviewed changes
sungchun12
sungchun12 reviewed Dec 28, 2023
View reviewed changes
sungchun12
sungchun12 reviewed Dec 28, 2023
View reviewed changes
sungchun12
sungchun12 reviewed Dec 28, 2023
View reviewed changes
sungchun12
sungchun12 reviewed Dec 28, 2023
View reviewed changes
sungchun12
sungchun12 reviewed Dec 28, 2023
View reviewed changes
@sungchun12 sungchun12 mentioned this pull request Dec 28, 2023
Closed
@sungchun12
Copy link
Contributor

Validate all unit tests pass: #819 (comment)
@sungchun12
Copy link
Contributor

@idling11 Can you run ruff format . on your forked branch and commit the change? Once that formatter test passes, I'll squash and merge this and we can cut a patch release!
@sungchun12 sungchun12 dismissed their stale review December 28, 2023 20:37

need to validate formatting test passes

@idling11
Copy link
Contributor Author

@sungchun12 Formated files and submitted.
sungchun12
sungchun12 approved these changes Dec 29, 2023
View reviewed changes
Copy link
Contributor

@sungchun12 sungchun12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests pass in a native branch for extra due diligence: #819
@sungchun12 sungchun12 merged commit 60ac169 into datafold:master Dec 29, 2023
@sungchun12
Copy link
Contributor

@idling11 Just merged and we'll likely cut a patch release next week! In the short term, you can use the datafold master branch!
@sungchun12
Copy link
Contributor

Thank you for contributing and your patience in this process. You helped uncover a lot of issues when work with forked branches in our CI process. Next time you contribute, you'll have a much better experience and it's thanks to you :)
This was referenced Dec 30, 2023
Merged
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

2 participants

@idling11 @sungchun12