- Notifications
You must be signed in to change notification settings - Fork 296
README updates for coalesce and pre release #241
Conversation
Merge branch 'master' into readme-ideas
Overall I'm okay with these changes, but I think it was good to have the benchmark graph prominent, since data-diff's main feature is its speed. I don't think it's a good idea to push it down to the technical explanation. Ideally, we should re-run the benchmarks to include the in-db diff (joindiff), and we can re-write the explanation for the benchmark so it's a little less technical. |
Thanks for the feedback @erezsh, I appreciate it! Just to be clear, I don't think we should merge this yet--it was meant as a work in progress and first draft so I could collect feedback and make updates. I'd love to schedule some time to meet and chat about this all next week, when I start full-time as a Solutions Engineer. I agree with you that we should re-run benchmarks with joindiff. Is that something you'd be able to do? Even if it's not presentation-ready, I'd be interested in the results. In addition to the When I start FT next week, I'll be more than happy to help where I can to develop these benchmarks and messaging. |
Sounds good. From initial running, it seems joindiff is about x3 to x4 faster than hashdiff on the same db. But I'll run a more exact benchmark soon. P.S. you can mark your PRs as 'draft', if you don't want them merged yet. |
Thanks @erezsh ! Marked it as draft. 🙌 |
Also borrowed some formatting / organization from dbt-core readme
Just a reminder that this is very much in flight, so if you take a look, please keep its WIP 🚧 👷 status in mind! 😇 |
… into readme-ideas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
Per my discussion with @williebsweet, I'm putting together some ideas for making the README (and eventually the datafold docs) more accessible and digestible for a less technical first-time user.