Skip to content

Added our contribution guidelines #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ddmkr merged 1 commit into from
Mar 25, 2021
Merged

Added our contribution guidelines #56

ddmkr merged 1 commit into from
Mar 25, 2021

Conversation

@ddmkr
Copy link
Contributor

@ddmkr ddmkr commented Mar 25, 2021

  • Updated the main README.md
  • Added an additional CONTRIBUTING.md page.
@ddmkr ddmkr requested a review from lvanacken March 25, 2021 15:54
@vercel
Copy link

vercel bot commented Mar 25, 2021

@ddmkr is attempting to deploy a commit to the Day One Labs Team on Vercel.

To accomplish this, @ddmkr needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.
lvanacken
lvanacken reviewed Mar 25, 2021
View reviewed changes
README.md

## Contributing

We welcome all sorts of contributions, be it new features, bug fixes or documentation, we encourage you to create a new PR. To create a new PR or to report new bugs, please read how to [contribute to RDocumentation](./CONTRIBUTING.md).
Copy link

@lvanacken lvanacken Mar 25, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The contributing document does not explain whether there is a PR process. Not sure we need to be more specific as I don't think we will have a real process that is relevant.
Copy link
Contributor Author

@ddmkr ddmkr Mar 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, thought about it. Viewflow has a small section on making PRs. We could add something similar? https://github.com/datacamp/viewflow/blob/master/CONTRIBUTION.md
Copy link

@lvanacken lvanacken Mar 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes that's very nimble - worth adding.
lvanacken
lvanacken approved these changes Mar 25, 2021
View reviewed changes
Copy link

@lvanacken lvanacken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made one comment, but don't think it needs addressing.
@ddmkr ddmkr merged commit 3209b41 into main Mar 25, 2021
@ddmkr ddmkr deleted the ddmkr/add-contribution-guidelines branch March 25, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@ddmkr @lvanacken