Initial commit GxP validation #492
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| All commits in PR should be signed ('git commit -S ...'). See https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits |
alexott requested changes Jul 4, 2025
Comment on lines +199 to +202
| list_clusters_url = f"{workspace_url}/api/2.0/clusters/list" | ||
| response = requests.get(list_clusters_url, headers=headers) | ||
| response.raise_for_status() | ||
| clusters = response.json().get("clusters", []) |
Contributor
There was a problem hiding this comment.
We should use SDK, especially because it's bundled with DBRs
Contributor
There was a problem hiding this comment.
Also, 2.0 API for clusters is outdated and won't work if you have a large number of clusters
Contributor
There was a problem hiding this comment.
| | ||
| # Check access mode (data_security_mode) | ||
| access_mode = cluster_info.get("data_security_mode", "NONE") | ||
| access_mode_names = { |
Contributor
There was a problem hiding this comment.
there are new modes as well, when cluster has kind configured
Author
| Will close this one because we'll move it to the other repo |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Initial commit for the GxP validation scripts library.
The project aims to create a unified industry-wide approach to GxP validation of Pharmaceutical platforms built on Databricks.
Main contributors will be Oleksandra Bovkun, Neha Pande, and selected Databricks customers