Better error handling in Repos #428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## master #428 +/- ## ========================================== - Coverage 86.21% 86.06% -0.15% ========================================== Files 41 41 Lines 2887 2892 +5 ========================================== Hits 2489 2489 - Misses 398 403 +5
Continue to review full report at Codecov.
|
a-cong approved these changes Feb 4, 2022
Contributor
| Changes LGTM, however, it would be good to add unit tests for the new code paths before merging |
In current version, we have "catch-all" error handling that efficiently hides the actual reason for the error. It's not possible to understand the reason for error, for example, when IP Access List is used. This patch improves the error reporting: Without patch ``` Error: RuntimeError: Can't find repo ID for /Repos/user/repo ``` With patch: ``` Error: RuntimeError: Error fetching repo ID for /Repos/user/repo: HTTP code: 403, Unauthorized access to Org: 1234567890 ```
Contributor Author
| I've added a test, but I can't see what actual coverage change is |
Contributor Author
| @jaipreet-s how I can re-run tests to get new coverage? |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
In current version, we have "catch-all" error handling that efficiently hides the actual reason for the error. It's not possible to understand the reason for error, for example, when IP Access List is used. This patch improves the error reporting:
Without patch
With patch: