Skip to content

Conversation

@SkyFan2002
Copy link
Member

@SkyFan2002 SkyFan2002 commented Sep 19, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  1. By design, if a DDL statement is executed while a transaction is active, the DDL statement will implicitly commits the active transaction. This pr supports this behavior when ddl is in a procedure.
  2. Add stored procedure tests covering transaction scenarios including rollback behavior, snapshot management, merge operations, deduplication labels, and multi-procedure transactions.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Sep 19, 2025
@SkyFan2002 SkyFan2002 marked this pull request as ready for review September 20, 2025 18:41
@dantengsky dantengsky merged commit ee0b686 into databendlabs:main Sep 22, 2025
93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix this PR patches a bug in codebase

2 participants