-
Couldn't load subscription status.
- Fork 832
feat(query): support shuffle sort #17853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Docker Image for PR
|
Docker Image for PR
|
8f49873 to 645dcb4 Compare Signed-off-by: coldWater <forsaken628@gmail.com>
Signed-off-by: coldWater <forsaken628@gmail.com>
44eb3e4 to 476ffde Compare 46a3e42 to 27a1b4c Compare 570d3c5 to aeaa31f Compare b85cdb4 to 4308c19 Compare sundy-li reviewed Jul 16, 2025
src/query/service/tests/it/sql/planner/optimizer/data/results/tpcds/Q03_physical.txt Show resolved Hide resolved
sundy-li approved these changes Jul 29, 2025
sundy-li approved these changes Jul 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Added settings
enable_shuffle_sort, disabled by default.Due to the complexity of the cut-point selection, which requires a lot of work to optimize.
Tests
Type of change
This change is