Skip to content

Conversation

@dantengsky
Copy link
Member

@dantengsky dantengsky commented Jul 8, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

refactor: rename metrics & tweak system.caches table

  • Column names of system.caches changed to
+------------------------+--------------------------------------------+-----------+------+ | node | name | num_items | size | +------------------------+--------------------------------------------+-----------+------+ | pEkQjwILMUbTu1GSJ0Vla1 | disk_cache_table_data | 0 | 0 | | pEkQjwILMUbTu1GSJ0Vla1 | memory_cache_bloom_index_file_meta_data | 0 | 0 | | pEkQjwILMUbTu1GSJ0Vla1 | memory_cache_bloom_index_filter | 0 | 0 | | pEkQjwILMUbTu1GSJ0Vla1 | memory_cache_compact_segment_info | 0 | 0 | | pEkQjwILMUbTu1GSJ0Vla1 | memory_cache_inverted_index_file | 0 | 0 | | pEkQjwILMUbTu1GSJ0Vla1 | memory_cache_inverted_index_file_meta_data | 0 | 0 | | pEkQjwILMUbTu1GSJ0Vla1 | memory_cache_parquet_file_meta | 0 | 0 | | pEkQjwILMUbTu1GSJ0Vla1 | memory_cache_prune_partitions | 0 | 0 | | pEkQjwILMUbTu1GSJ0Vla1 | memory_cache_table_data | 0 | 0 | | pEkQjwILMUbTu1GSJ0Vla1 | memory_cache_table_snapshot | 0 | 0 | | pEkQjwILMUbTu1GSJ0Vla1 | memory_cache_table_statistics | 0 | 0 | +------------------------+--------------------------------------------+-----------+------+ 
  • Metric names changed to
+-----------------------+--------------------------------------+---------+----------------------------------------------------+------------+ | node | metric | kind | labels | value | +-----------------------+--------------------------------------+---------+----------------------------------------------------+------------+ | opj7Vw9EjBbhQjnewuqWu | cache_access_count_total | counter | {"cache_name":"disk_cache_table_data"} | 18.0 | | opj7Vw9EjBbhQjnewuqWu | cache_access_count_total | counter | {"cache_name":"memory_cache_compact_segment_info"} | 3.0 | | opj7Vw9EjBbhQjnewuqWu | cache_access_count_total | counter | {"cache_name":"memory_cache_prune_partitions"} | 2.0 | | opj7Vw9EjBbhQjnewuqWu | cache_access_count_total | counter | {"cache_name":"memory_cache_table_data"} | 18.0 | | opj7Vw9EjBbhQjnewuqWu | cache_access_count_total | counter | {"cache_name":"memory_cache_table_snapshot"} | 4.0 | | opj7Vw9EjBbhQjnewuqWu | cache_hit_count_total | counter | {"cache_name":"memory_cache_compact_segment_info"} | 1.0 | | opj7Vw9EjBbhQjnewuqWu | cache_hit_count_total | counter | {"cache_name":"memory_cache_table_snapshot"} | 3.0 | | opj7Vw9EjBbhQjnewuqWu | cache_miss_count_total | counter | {"cache_name":"disk_cache_table_data"} | 27428119.0 | | opj7Vw9EjBbhQjnewuqWu | cache_miss_count_total | counter | {"cache_name":"memory_cache_compact_segment_info"} | 2.0 | | opj7Vw9EjBbhQjnewuqWu | cache_miss_count_total | counter | {"cache_name":"memory_cache_prune_partitions"} | 2.0 | | opj7Vw9EjBbhQjnewuqWu | cache_miss_count_total | counter | {"cache_name":"memory_cache_table_data"} | 27428119.0 | | opj7Vw9EjBbhQjnewuqWu | cache_miss_count_total | counter | {"cache_name":"memory_cache_table_snapshot"} | 1.0 | | opj7Vw9EjBbhQjnewuqWu | cache_population_pending_count_total | counter | {"cache_name":"disk_cache_table_data"} | 0.0 | +-----------------------+--------------------------------------+---------+----------------------------------------------------+------------+ 

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - covered by existing test cases

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Jul 8, 2024
@dantengsky dantengsky marked this pull request as ready for review July 8, 2024 13:43
@dantengsky dantengsky requested review from BohuTANG and wubx and removed request for wubx July 8, 2024 13:43
@BohuTANG BohuTANG merged commit 9ce86e5 into databendlabs:main Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-refactor this PR changes the code base without new features or bugfix

2 participants