Skip to content

refactor(query): propose renaming the cluster to warehouse #15211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

refactor(query): propose renaming the cluster to warehouse #15211

wants to merge 2 commits into from

Conversation

@zhang2014
Copy link
Member

@zhang2014 zhang2014 commented Apr 11, 2024 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

refactor(query): propose renaming the cluster to a warehouse

Compatible:
cluster_id in config
cluster_id field in system config
cluster_id labels in metrics
cluster_id tag in sentry

  • Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - propose

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable
@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Apr 11, 2024
@zhang2014 zhang2014 changed the title refactor(query): propose renaming the cluster to a warehouse refactor(query): propose renaming the cluster to warehouse Apr 11, 2024
@zhang2014
Merge branch 'main' into refactor/rename_cluster
4e442e8 
# Conflicts: #	src/query/service/src/schedulers/fragments/fragmenter.rs #	src/query/service/src/schedulers/fragments/query_fragment_actions.rs #	src/query/service/src/servers/flight/v1/exchange/exchange_sink.rs #	src/query/service/src/servers/flight/v1/exchange/exchange_source.rs #	src/query/service/src/servers/flight/v1/exchange/exchange_transform.rs
@flaneur2020
Copy link
Member

flaneur2020 commented Apr 12, 2024 •
edited
Loading

please pause this change until we get the concepts clarified, as a cloud service of databend, we might need a warehouse runs multiple clusters at the same time in the short term.
@zhang2014 zhang2014 closed this Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-refactor this PR changes the code base without new features or bugfix

2 participants

@zhang2014 @flaneur2020