Skip to content

refactor(query): disallowed tokio spawn and block_on #14639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 7, 2024
Merged

refactor(query): disallowed tokio spawn and block_on #14639

merged 10 commits into from
Feb 7, 2024
+180 −185

Conversation

@zhang2014
Copy link
Member

@zhang2014 zhang2014 commented Feb 7, 2024 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

refactor(query): disallowed tokio spawn and block_on

continue #14563

  • Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable
@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Feb 7, 2024
@zhang2014 zhang2014 marked this pull request as ready for review February 7, 2024 06:12
@zhang2014 zhang2014 added the ci-benchmark Benchmark: run all test label Feb 7, 2024
@zhang2014 zhang2014 added ci-benchmark Benchmark: run all test and removed ci-benchmark Benchmark: run all test labels Feb 7, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2024

Docker Image for PR

  • tag: pr-14639-26097a1

note: this image tag is only available for internal use,
please check the internal doc for more details.
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2024

Docker Image for PR

  • tag: pr-14639-4241711

note: this image tag is only available for internal use,
please check the internal doc for more details.
@zhang2014 zhang2014 added ci-benchmark Benchmark: run all test and removed ci-benchmark Benchmark: run all test labels Feb 7, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2024

Docker Image for PR

  • tag: pr-14639-4720285

note: this image tag is only available for internal use,
please check the internal doc for more details.
1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2024

Docker Image for PR

  • tag: pr-14639-4720285

note: this image tag is only available for internal use,
please check the internal doc for more details.
@BohuTANG BohuTANG added ci-benchmark Benchmark: run all test and removed ci-benchmark Benchmark: run all test labels Feb 7, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2024

Docker Image for PR

  • tag: pr-14639-09beef7

note: this image tag is only available for internal use,
please check the internal doc for more details.
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2024

ClickBench Report
@BohuTANG BohuTANG merged commit 47803fb into databendlabs:main Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-benchmark Benchmark: run all test pr-refactor this PR changes the code base without new features or bugfix

2 participants

@zhang2014 @BohuTANG