Skip to content

refactor(query): support additional param to set the error rate in approx_count_distinct function #14609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 7, 2024
Merged

refactor(query): support additional param to set the error rate in approx_count_distinct function #14609

merged 9 commits into from
Feb 7, 2024

Conversation

@sundy-li
Copy link
Member

@sundy-li sundy-li commented Feb 5, 2024 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

support additional param to set the error rate in approx_count_distinct function

part of #14585 without modification of meta

  • Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable
@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Feb 5, 2024
@sundy-li sundy-li marked this pull request as draft February 6, 2024 11:09
@sundy-li sundy-li requested review from ariesdevil and b41sh February 7, 2024 01:48
@sundy-li sundy-li marked this pull request as ready for review February 7, 2024 01:48
@sundy-li sundy-li enabled auto-merge February 7, 2024 04:14
@sundy-li sundy-li added this pull request to the merge queue Feb 7, 2024
Merged via the queue into databendlabs:main with commit f7a4b80 Feb 7, 2024
@sundy-li sundy-li deleted the hyperloglog-sparse branch February 7, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-refactor this PR changes the code base without new features or bugfix

2 participants

@sundy-li @ariesdevil