Skip to content

refactor(executor): refactor processor profiling #14377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Jan 24, 2024
Merged

refactor(executor): refactor processor profiling #14377

merged 18 commits into from
Jan 24, 2024

Conversation

@zhang2014
Copy link
Member

@zhang2014 zhang2014 commented Jan 18, 2024 •
edited by BohuTANG
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  • Add new profiling type
  • Add plan labels in profiling log
  • Add plan title in profiling log
  • Easier recording of processor profiling value
Profile::record_usize_profile(ProfileStatisticsName::ScanCacheBytes, process_values.bytes);
  • Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable
@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Jan 18, 2024
@zhang2014 zhang2014 added the ci-benchmark Benchmark: run all test label Jan 18, 2024
@github-actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-14377-4c682ea

note: this image tag is only available for internal use,
please check the internal doc for more details.
@github-actions
Copy link
Contributor

cloud cloud

ClickBench Report
@zhang2014 zhang2014 added ci-benchmark Benchmark: run all test ci-cloud Build docker image for cloud test and removed ci-benchmark Benchmark: run all test labels Jan 24, 2024
@github-actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-14377-5d4d4d0

note: this image tag is only available for internal use,
please check the internal doc for more details.
@github-actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-14377-5d4d4d0

note: this image tag is only available for internal use,
please check the internal doc for more details.
@github-actions
Copy link
Contributor

cloud cloud

ClickBench Report
@github-actions
Copy link
Contributor

cloud cloud

ClickBench Report
@zhang2014 zhang2014 added ci-benchmark Benchmark: run all test and removed ci-benchmark Benchmark: run all test labels Jan 24, 2024
@zhang2014 zhang2014 marked this pull request as ready for review January 24, 2024 03:30
@zhang2014 zhang2014 requested a review from BohuTANG January 24, 2024 03:30
@zhang2014 zhang2014 added ci-cloud Build docker image for cloud test and removed ci-cloud Build docker image for cloud test labels Jan 24, 2024
@github-actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-14377-893a450

note: this image tag is only available for internal use,
please check the internal doc for more details.
@github-actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-14377-dc22d1b

note: this image tag is only available for internal use,
please check the internal doc for more details.
@zhang2014 zhang2014 added ci-benchmark Benchmark: run all test and removed ci-benchmark Benchmark: run all test labels Jan 24, 2024
@github-actions
Copy link
Contributor

cloud cloud

ClickBench Report
@github-actions
Copy link
Contributor

cloud cloud

ClickBench Report
@BohuTANG BohuTANG added ci-benchmark Benchmark: run all test and removed ci-benchmark Benchmark: run all test labels Jan 24, 2024
@github-actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-14377-f845e90

note: this image tag is only available for internal use,
please check the internal doc for more details.
@github-actions
Copy link
Contributor

cloud cloud

ClickBench Report
@zhang2014 zhang2014 marked this pull request as draft January 24, 2024 07:40
@zhang2014 zhang2014 marked this pull request as ready for review January 24, 2024 08:03
@BohuTANG BohuTANG added ci-benchmark Benchmark: run all test and removed ci-benchmark Benchmark: run all test labels Jan 24, 2024
@github-actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-14377-ab4fce5

note: this image tag is only available for internal use,
please check the internal doc for more details.
@github-actions
Copy link
Contributor

cloud cloud

ClickBench Report
@BohuTANG BohuTANG merged commit fbc9a5a into main Jan 24, 2024
@BohuTANG BohuTANG deleted the refactor/profiling branch January 24, 2024 12:25
yufan022 pushed a commit to yufan022/databend that referenced this pull request Apr 25, 2024
@zhang2014 @yufan022
refactor(executor): refactor processor profiling (databendlabs#14377)
ebf04fd 
* refactor(executor): refactor processor profiling * refactor(executor): refactor processor profiling * refactor(executor): refactor processor profiling * refactor(executor): refactor processor profiling * refactor(executor): refactor processor profiling * refactor(executor): refactor processor profiling * refactor(executor): refactor processor profiling * refactor(executor): refactor processor profiling * refactor(executor): refactor processor profiling * refactor(executor): refactor processor profiling * refactor(executor): refactor processor profiling * refactor(executor): refactor processor profiling * refactor(executor): refactor processor profiling * refactor(executor): refactor processor profiling * refactor(executor): refactor processor profiling * refactor(executor): refactor processor profiling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-benchmark Benchmark: run all test ci-cloud Build docker image for cloud test pr-refactor this PR changes the code base without new features or bugfix

3 participants

@zhang2014 @BohuTANG