Skip to content

chore(executor): add exchange row and bytes profile #14067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 19, 2023
Merged

chore(executor): add exchange row and bytes profile #14067

merged 2 commits into from
Dec 19, 2023

Conversation

@zhang2014
Copy link
Member

@zhang2014 zhang2014 commented Dec 18, 2023 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

chore(executor): add exchange row and bytes profile

Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Dec 18, 2023
@zhang2014 zhang2014 requested a review from xudong963 December 18, 2023 14:09
@zhang2014 zhang2014 marked this pull request as ready for review December 18, 2023 14:28
@zhang2014 zhang2014 added this pull request to the merge queue Dec 18, 2023
@zhang2014 zhang2014 removed this pull request from the merge queue due to a manual request Dec 18, 2023
@zhang2014 zhang2014 added the ci-benchmark Benchmark: run all test label Dec 18, 2023
@github-actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-14067-e3c85c0

note: this image tag is only available for internal use,
please check the internal doc for more details.
@github-actions
Copy link
Contributor

cloud cloud

ClickBench Report
1 similar comment
@github-actions
Copy link
Contributor

cloud cloud

ClickBench Report
@BohuTANG
Copy link
Member

BohuTANG commented Dec 19, 2023 •
edited
Loading

Cluster is degression, does this is by design?

image

benchmark
@BohuTANG
Copy link
Member

The degression seems not related to this PR but v1.2.260-nightly:
image
@BohuTANG BohuTANG merged commit 9361cf3 into databendlabs:main Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-benchmark Benchmark: run all test pr-chore this PR only has small changes that no need to record, like coding styles.

3 participants

@zhang2014 @BohuTANG @xudong963