Skip to content

Conversation

@Chasen-Zhang
Copy link
Member

No description provided.

@vercel
Copy link

vercel bot commented Oct 31, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs Building Building Preview Comment Oct 31, 2025 4:13am
@Chasen-Zhang Chasen-Zhang merged commit 37da65c into main Oct 31, 2025
3 of 4 checks passed
@Chasen-Zhang Chasen-Zhang deleted the add-marquee branch October 31, 2025 04:13
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +1 to +5
// Copyright 2025 DatabendLabs.
import { Flex } from "antd";
import type { FC, ReactElement } from "react";
import Slider from "react-slick";
import styles from "./styles.module.scss";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Import slick carousel styles for marquee

The new marquee uses react-slick, but no base slick styles are imported or provided. Without the CSS from slick-carousel (e.g. slick.css/slick-theme.css), the slider renders all announcements stacked and doesn’t animate because the required overflow and track positioning rules are missing. This will be visible on every Chinese docs page where the banner is shown. Please include the slick styles (or equivalent custom styles) so the marquee behaves as intended.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants