Skip to content

add an action to deploy to github pages when pushed to master. #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 14, 2020
Merged

add an action to deploy to github pages when pushed to master. #81

merged 8 commits into from
Nov 14, 2020

Conversation

@tonyfast
Copy link
Contributor

@tonyfast tonyfast commented Nov 10, 2020

fixes #75
rgommers
rgommers reviewed Nov 10, 2020
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tonyfast! Looks great, just a few comments. The last one is the most important, latest/ needs to be in the URLs to not break incoming links.
@tonyfast
Copy link
Contributor Author

tonyfast commented Nov 10, 2020

i resolved your comments. i set up the actions to create an artifact of the documents so they can be previewed. the github pages deployment only updates on changes to master.
@tonyfast tonyfast requested a review from rgommers November 13, 2020 17:08
rgommers
rgommers approved these changes Nov 14, 2020
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my fork and fixed all remaining issues, let's give this a go! Thanks @tonyfast!
@rgommers rgommers merged commit 192c047 into data-apis:master Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@tonyfast @rgommers