Skip to content

Add version to the page #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2023
Merged

Add version to the page #662

merged 1 commit into from
Jul 20, 2023

Conversation

steff456
Copy link
Member

Fixes #651

This PR adds the version to the nav title so it will be visible in the header and in the sidebar. This is how it looks with the changes for the current versions,

Version 2021.12
image

Version 2022.12
image

Draft version
image

I don't love how the Draft version looks, I don't know if there's a preference between uppercase, lowercase or capitalized.
@steff456 steff456 added the RFC Request for comments. Feature requests and proposed changes. label Jul 19, 2023
@steff456 steff456 self-assigned this Jul 19, 2023
@steff456 steff456 changed the title Add version to the nav title Add version to the page Jul 19, 2023
kgryte
kgryte approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @steff456!
@kgryte
Copy link
Contributor

kgryte commented Jul 19, 2023

Having DRAFT in constant case is fine with me.
rgommers
rgommers approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too, thanks @steff456

Having DRAFT in constant case is fine with me.

Seems fine indeed, and we're free to change our minds later. So let's get this in as is.
@rgommers rgommers merged commit e72b3ca into data-apis:main Jul 20, 2023
@rgommers rgommers added the Document Formatting Document formatting or styling. label Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Document Formatting Document formatting or styling. RFC Request for comments. Feature requests and proposed changes.

3 participants

@steff456 @kgryte @rgommers