Skip to content

Add floor_divide and remainder #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2020
Merged

Add floor_divide and remainder #56

merged 1 commit into from
Oct 22, 2020

Conversation

@kgryte
Copy link
Contributor

@kgryte kgryte commented Oct 19, 2020

This PR

  • adds specifications for floor_divide and remainder, which are the functional equivalents of the // and % Python operators, respectively.
  • follows the conventions set forth by existing element-wise functions.

Notes

  • TensorFlow uses the alias floordiv. Went with floor_divide as more common.
  • The functions in this PR ensure functional equivalents of the Python operators // and %, as discussed in consortium meetings.
rgommers
rgommers approved these changes Oct 20, 2020
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kgryte. This should be uncontroversial, I'll merge soon unless there are more comments.
@rgommers rgommers merged commit dc65531 into master Oct 22, 2020
@rgommers rgommers deleted the elementwise-2 branch October 22, 2020 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@kgryte @rgommers