Remove axis kwarg support from linalg.matrix_norm #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
kgryte added API change | cc @asmeurer for visibility. |
| Will merge. We can revisit the inclusion of an |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR
axiskwarg inlinalg.matrix_norm. The current specification derives its signature from a previously unifiednormAPI which had to cater to both vector and matrix use cases. In the current specification,matrix_normis unique amonglinalgAPIs in supporting anaxiskwarg for an API operating on stacks of matrices. And as this API is relatively new among array libraries, seems most prudent to hold off including anaxiskwarg until array libraries have come to a consensus that providingaxissupport is desirable. In general, easier to add to the standard, rather than take something away.