Skip to content

Conversation

@kgryte
Copy link
Contributor

@kgryte kgryte commented Aug 31, 2020

This PR

  • adds specifications for element-wise comparison functions.
  • is derived from comparing API signatures across array libraries.

Notes

  • Element-wise comparison functions are widely implemented across array libraries and are used, to some extent, by downstream libraries. Apart from being widely implemented, a principal reason for their inclusion is to provide standardized public APIs which can be passed around (e.g., when composing functional pipelines, etc).
  • The proposed specifications follow the same general form as arithmetic operations, which are already present in the specification, and share the same concerns as other element-wise interfaces concerning broadcast compatibility.
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. And I think we should put the note about operator - function equivalents elsewhere, so these are quite straightforward.

@kgryte
Copy link
Contributor Author

kgryte commented Aug 31, 2020

@rgommers Agreed. Will submit another PR with a doc detailing operator equivalents.

@rgommers
Copy link
Member

rgommers commented Sep 8, 2020

Merging, thanks @kgryte

@rgommers rgommers merged commit 84a4804 into master Sep 8, 2020
@rgommers rgommers deleted the comparison branch September 8, 2020 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants