Skip to content

Add logical function specifications #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 8, 2020
Merged

Add logical function specifications #26

merged 1 commit into from
Sep 8, 2020

Conversation

@kgryte
Copy link
Contributor

@kgryte kgryte commented Aug 27, 2020

This PR

  • adds specifications for logical functions.
  • is derived from comparing API signatures across array libraries.

Notes

  • Logical functions are widely implemented across array libraries and are used by downstream libraries.
  • TensorFlow is more restrictive in requiring boolean Tensors. The current spec follows NumPy, Torch, and others in performing logical operations based on a looser definition of "truthiness".
  • The proposed specifications follow the same general form as arithmetic operations, which are already present in the specification, and share the same concerns as other element-wise interfaces concerning broadcast compatibility.
@rgommers
Copy link
Member

rgommers commented Sep 8, 2020

This is quite straightforward and no comments for over a week, I'll merge it. Thanks @kgryte
@rgommers rgommers merged commit a24ac53 into master Sep 8, 2020
@rgommers rgommers deleted the logical-functions branch September 8, 2020 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@kgryte @rgommers