Skip to content

BUG: add test that wrapping preserves view/copy semantics, fix where it doesn't #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 10, 2025
Merged

BUG: add test that wrapping preserves view/copy semantics, fix where it doesn't #333

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c9cfc2c
TST: add a test that wrapping preserves a view/copy semantics for una…
ev-br Jun 1, 2025
1facc35
BUG: make ceil,trunc,floor always respect view/copy semantics
ev-br Jun 1, 2025
0ad664b
Apply suggestions from code review
ev-br Jun 4, 2025
118ae2d
TST: test views vs copies on array-api-strict, too
ev-br Jun 4, 2025
b0eed55
Apply suggestions from code review
ev-br Jun 4, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Guido Imperiale <crusaderky@gmail.com>
  • Loading branch information
@ev-br @crusaderky
ev-br and crusaderky committed Jun 4, 2025
commit 0ad664bdfde03ec3f21d82b1048616ae5d0fb6b7
4 changes: 2 additions & 2 deletions tests/test_copies_or_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
on whether to return a view or a copy of inputs.
"""
import pytest
from ._helpers import import_
from ._helpers import import_, wrapped_libraries


LIB_NAMES = ['numpy', 'cupy', 'torch', 'dask.array', 'array_api_strict']
Expand Down Expand Up @@ -40,7 +40,7 @@ def is_view(func, a, value):
return a[0] == value


@pytest.mark.parametrize('xp_name', LIB_NAMES)
@pytest.mark.parametrize('xp_name', wrapped_libraries)
@pytest.mark.parametrize('inputs', FUNC_INPUTS, ids=[inp[0] for inp in FUNC_INPUTS])
def test_view_or_copy(inputs, xp_name):
bare_xp = import_(xp_name, wrapper=False)
Expand Down