Skip to content

ENH: More uint types for torch #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2025
Merged

ENH: More uint types for torch #244

merged 1 commit into from
Jan 31, 2025

Conversation

@crusaderky
Copy link
Contributor

No description provided.

ev-br
ev-br approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@ev-br ev-br left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense!
@ev-br
Copy link
Member

ev-br commented Jan 29, 2025

Note that due to the way automation is set up in this repository, Ci failures --- even if unrelated --- block merges and releases (hint hint).

  • clip failure is a flaky test, might disappear on a rerun (a better fix would be much appreciated of course)
  • dask's error, Original Message: Can not use auto rechunking with object dtype. We are unable to estimate the size in bytes of object data, is something new and probably due to recent dask effort
@crusaderky
Copy link
Contributor Author

data-apis/array-api-tests#338
@ev-br ev-br closed this Jan 31, 2025
@ev-br ev-br reopened this Jan 31, 2025
@ev-br
Copy link
Member

ev-br commented Jan 31, 2025

The change LGTM. It effectively bumps the torch requirement to >= 2.3, which is likely fine.

I'm going to carpe diem while the CI is green after #246 and press the green button.

Thanks @crusaderky
@ev-br ev-br merged commit 2eafb97 into data-apis:main Jan 31, 2025
79 of 84 checks passed
@crusaderky crusaderky deleted the torch_uint branch January 31, 2025 11:42
@ev-br ev-br mentioned this pull request Feb 25, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@crusaderky @ev-br