Remove extra version info #2539
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Closes #2535 Add a check for the `workspace_ref.json` file in place of the `pubspec.lock` file that exists for single package pub solutions. When the workspace ref exists, follow it and read the `package_graph.json` file from the workspace root.
The test had been passing because the `testVersion` variable was null in the pub workspace which matched the behavior of the test_descriptor package within the test..
Follow up to #2538 This is only relevant when using the test runner as a git or path dependency. In these cases the version will already end in `-WIP` with out current development practices and in the places where it may come up the users don't need help understanding where the code is coming from.
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Follow up to #2538
This is only relevant when using the test runner as a git or path
dependency. In these cases the version will already end in
-WIPwithout current development practices and in the places where it may come up
the users don't need help understanding where the code is coming from.