Skip to content

Conversation

@devoncarew
Copy link
Contributor

  • add a pull request labeler
  • add issue tracker links
  • update the codeowners file
  • move fake_async to using its own workflow file

Some notes:

  • this is multiplexing package test, test_api, and test_core into one label - package:test; not sure if this is desired or not
  • this PR doesn't rev. pubspec versions for the issue_tracker: change; I figure that that change will just be picked up with the next general publish of the packages

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@devoncarew devoncarew requested a review from a team as a code owner January 24, 2025 18:13
# These are suggestions; it is fine to have your changes reviewed by someone
# else.

/pkgs/checks/ @dart-lang/core-package-admins
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @natebosch and @jakemac53 re: whether these 5 packages match up w/ what you want auto-assigned for review

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Jan 24, 2025

PR Health

Co-authored-by: Kevin Moore <kevmoo@users.noreply.github.com>
@jakemac53
Copy link
Contributor

  • this is multiplexing package test, test_api, and test_core into one label - package:test; not sure if this is desired or not

Yeah that sounds right to me

@devoncarew devoncarew merged commit ad04f17 into master Jan 25, 2025
65 checks passed
@devoncarew devoncarew deleted the repo_metadata branch January 25, 2025 00:06
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Jan 27, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`. core (https://github.com/dart-lang/core/compare/72a2060..3b35aca): 3b35aca9 2025-01-24 Devon Carew update the topics section of several pubspecs (dart-lang/core#854) ecosystem (https://github.com/dart-lang/ecosystem/compare/682c8ef..c4a163a): c4a163a 2025-01-23 Devon Carew print detailed info about the leaked APIs to stdout in the workflow (dart-lang/ecosystem#339) test (https://github.com/dart-lang/test/compare/7fc9521..92eed6c): 92eed6c4 2025-01-27 Lasse R.H. Nielsen Make zone handlers call zone.run to run callbacks. (dart-lang/test#2451) ad04f172 2025-01-24 Devon Carew add a pull request labeler; add issue tracker links; update codeowners file (dart-lang/test#2452) 1f292db8 2025-01-24 Lasse R.H. Nielsen Don't require Dart 3.5. a56fa947 2025-01-24 Lasse R.H. Nielsen Accept extra `run`s in test. Move to Dart 3.5. 4bd54972 2025-01-24 Lasse R.H. Nielsen Clean-up. Accidentally merged a removed lint back in. 9fa57d16 2025-01-24 Lasse R.H. Nielsen Make zone handlers call zone.run to run callbacks. webdev (https://github.com/dart-lang/webdev/compare/9430dd7..5dc7950): 5dc79508 2025-01-24 Jessy Yameogo Added support for callLibraryMethod with the DDC library bundle format. (dart-lang/webdev#2577) 1d0b32c2 2025-01-24 Srujan Gaddam Reset DWDS to 24.3.4-wip (dart-lang/webdev#2580) 1990d29a 2025-01-23 Srujan Gaddam Implement hot restart for DDC library bundle format and publish 24.3.3 (dart-lang/webdev#2576) Change-Id: Ifa23e74a1399ac7ec70a99750419b915a2efbb19 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/406120 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Auto-Submit: Devon Carew <devoncarew@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment