Always pass a function to BooleanSelector.evaluate #1125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Prepare for a potential breaking change in `package:boolean_selector`. Currently the `evaluate` method takes an argument which is either an `Iterable<String>` or a `bool Function(String)` which matches the `.toSet()contains` tearoff on that Iterable. We might tighten that to always take a `bool Function(String)` since the tearoff is easy to handle at the calling side.
jakemac53 approved these changes Dec 18, 2019
grouma approved these changes Dec 18, 2019
natebosch added a commit that referenced this pull request Jan 24, 2020
The breaking changes were handled in #1125
natebosch added a commit that referenced this pull request Jan 24, 2020
The breaking changes were handled in #1125
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Prepare for a potential breaking change in
package:boolean_selector.Currently the
evaluatemethod takes an argument which is either anIterable<String>or abool Function(String)which matches the.toSet()containstearoff on that Iterable. We might tighten that toalways take a
bool Function(String)since the tearoff is easy tohandle at the calling side.