Skip to content

Fixes dart-lang#58 #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2019
Merged

Fixes dart-lang#58 #61

merged 1 commit into from
Jan 9, 2019

Conversation

@itzsaga
Copy link

@itzsaga itzsaga commented Jan 9, 2019

I think this one is pretty straightforward.
@Colbitron
Copy link

Colbitron commented Jan 9, 2019

Beat me to the punch! For what it's worth, I can verify it works.
@itzsaga
Copy link
Author

itzsaga commented Jan 9, 2019

@Colbitron ha, yeah I saw this earlier after trying to run a brew upgrade and finally had a few minutes to spare to open the PR.
@kevmoo
Copy link
Member

kevmoo commented Jan 9, 2019

@whesse @athomas – I'm tempted to land this now to fix the existing issue. We'll need to make sure the next SDK roll we publish has these changes, too!
1 similar comment
@kevmoo
Copy link
Member

kevmoo commented Jan 9, 2019

@whesse @athomas – I'm tempted to land this now to fix the existing issue. We'll need to make sure the next SDK roll we publish has these changes, too!
@kevmoo kevmoo merged commit b371044 into dart-lang:master Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@itzsaga @Colbitron @kevmoo @googlebot