Upgrade dependencies #114
Merged
Upgrade dependencies #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
whesse approved these changes Aug 30, 2022
Contributor
whesse left a comment
whesse left a comment There was a problem hiding this comment.
If there is ever a breaking change where stable and dev don't have a common set of resolved packages, we would need to run pub upgrade in the test runs.
Member Author
We need to handle that when it happens. It doesn't help if the tests pass but the releases fail. If we upgrade, we also pickup breaking changes in the packages. The dev CI check is mostly a canary, the actual tooling would be run with the current checked-in SDK (so it really should work for all checked-in SDKs used on main, dev, beta and stable). |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.