Add actor reference #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
artursouza suggested changes Mar 11, 2021
artursouza reviewed Mar 11, 2021
After thinking about it and trying to understand usages, I don't think this should be deprecated at this time.
withinboredom force-pushed the add/actor-reference branch from 43dd705 to dd5fc27 Compare withinboredom added a commit that referenced this pull request Apr 10, 2021
* Update dependencies * Update daprd * feat: add shutdown (#80) * feat: add shutdown * Adds params and throw attributes * Add param description * Add a helper to shutdown at the end of the request * Ensure unit tests using the mock client will fail if they try to call the sidecar after shutting it down. * Use POST to shutdown Co-authored-by: Rob Landers <landers.robert@gmail.com> * Add actor reference (#71) * Add actor reference * Add 'get from interface' * Use interface instead * fix bad var name * Add actor reference to tests * Implement an actor reference and address * ok, I think I like the way it works now * Add deprecation to actor reference * Revert format change * Revert comment * Add more tests * not going to deprecate actor proxy After thinking about it and trying to understand usages, I don't think this should be deprecated at this time. Co-authored-by: Hugome <Hugome@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
This adds support for an Actor Reference that is serializable.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to
implementation.
Please reference the issue this PR will close: #66
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: