Skip to content

Conversation

@withinboredom
Copy link
Member

@withinboredom withinboredom commented Feb 28, 2021

Description

Adds a file cache for actors to reduce network requests while an actor is activated.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to
implementation.

Please reference the issue this PR will close: #60

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation
@withinboredom withinboredom added the enhancement New feature or request label Feb 28, 2021
@withinboredom withinboredom self-assigned this Feb 28, 2021
@dapr dapr deleted a comment from codecov-io Feb 28, 2021
@codecov-io
Copy link

Codecov Report

Merging #61 (807c851) into main (1c6c047) will increase coverage by 0.32%.
The diff coverage is 85.13%.

Impacted file tree graph

@@ Coverage Diff @@ ## main #61 +/- ## ============================================ + Coverage 73.23% 73.56% +0.32%  - Complexity 360 385 +25  ============================================ Files 45 47 +2 Lines 1349 1407 +58 ============================================ + Hits 988 1035 +47  - Misses 361 372 +11 
Impacted Files Coverage Δ Complexity Δ
src/config.php 100.00% <ø> (ø) 0.00 <0.00> (ø)
src/lib/Actors/Internal/Caches/NoCache.php 66.66% <66.66%> (ø) 5.00 <5.00> (?)
src/lib/Actors/ActorRuntime.php 95.95% <82.35%> (-2.84%) 31.00 <3.00> (+5.00) ⬇️
src/lib/Actors/ActorState.php 91.89% <87.50%> (-3.50%) 25.00 <0.00> (+2.00) ⬇️
src/lib/Actors/Internal/Caches/FileCache.php 88.88% <88.88%> (ø) 13.00 <13.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c6c047...807c851. Read the comment docs.

@withinboredom withinboredom merged commit 1db57c1 into main Feb 28, 2021
@withinboredom withinboredom deleted the update/actors branch February 28, 2021 11:06
@withinboredom withinboredom added this to the v1.0.1 milestone Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

3 participants