Skip to content

Conversation

@Marketen
Copy link
Contributor

This pull request updates the logic for generating git tags during the GitHub release process, especially for multi-variant packages. The main improvement is that the getNextGitTag function now consistently uses the variant@v<version> format for all multi-variant releases, even if there is only one variant. This change ensures more predictable and uniform tag naming. The update also propagates the new isMultiVariant parameter through the relevant release tasks.

Release tag generation improvements:

  • Updated getNextGitTag in getNextGitTag.ts to accept an isMultiVariant parameter and always use the variant@v<version> format for multi-variant packages, even with a single variant. The fallback for legacy behavior is preserved if isMultiVariant is not set.
  • Updated getHandleTagsTask and getCreateReleaseTask to accept and pass the isMultiVariant parameter, ensuring consistent tag generation throughout the release process. [1] [2] [3] [4]
@Marketen Marketen requested a review from a team as a code owner October 21, 2025 15:00
@Marketen Marketen requested a review from Copilot October 21, 2025 15:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the git tag generation logic for GitHub releases to consistently use the variant@v<version> format for all multi-variant packages, including cases where only a single variant exists. The change ensures more predictable and uniform tag naming across the release process.

Key Changes:

  • Modified getNextGitTag to accept an isMultiVariant parameter that enforces variant@v<version> format when true, regardless of variant count
  • Updated release task functions to accept and pass through the isMultiVariant parameter
  • Preserved legacy fallback behavior for backwards compatibility

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/tasks/createGithubRelease/getNextGitTag.ts Updated tag generation logic to use variant@v<version> format when isMultiVariant is true, even for single variants
src/tasks/createGithubRelease/subtasks/getHandleTagsTask.ts Added isMultiVariant parameter and passed it to getNextGitTag
src/tasks/createGithubRelease/subtasks/getCreateReleaseTask.ts Passed isMultiVariant parameter to getNextGitTag call
src/tasks/createGithubRelease/index.ts Propagated isMultiVariant parameter to getHandleTagsTask

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link

github-actions bot commented Oct 21, 2025

Dappnode bot has built and pinned the built packages to an IPFS node, for commit: c675fff

This is a development version and should only be installed for testing purposes.

  1. Package dappnodesdk.public.dappnode.eth

Install link

Hash: /ipfs/QmZNDZgWRG6NJhJRfVHUrHU2XMCC1zm1H2v2UtUFEHwiUM

(by dappnodebot/build-action)

Marketen and others added 2 commits October 21, 2025 17:03
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@pablomendezroyo pablomendezroyo merged commit 87ac3ac into master Oct 21, 2025
7 checks passed
@pablomendezroyo pablomendezroyo deleted the marc/keepnetworkforsinglevariants branch October 21, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants