Rework compile_commands.json import #8030
Open
+252 −141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ludviggunne force-pushed the cdb-parse-rewrite branch 2 times, most recently from 3792859 to 7941aae Compare 
Collaborator
| The clang-tidy warning seems to be a false positive, I have reported it here: llvm/llvm-project#172018 |
danmar reviewed Dec 14, 2025
Owner
danmar left a comment
danmar left a comment There was a problem hiding this comment.
I have not checked it in detail yet but this is better approach in my opinion. 👍
I feel we shouldn't merge this before the release though it could introduce some bug.
ludviggunne force-pushed the cdb-parse-rewrite branch from baef836 to a803280 Compare ludviggunne force-pushed the cdb-parse-rewrite branch from a803280 to 5fbb9e0 Compare ludviggunne force-pushed the cdb-parse-rewrite branch from 5fbb9e0 to b6c9031 Compare 
|
chrchr-github added the merge-after-next-release Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There has been multiple issues with the import lately, and (my) fixes have been a bit hacky. With this change,
commandis first split similarily to how the shell would, and is then handled like theargumentsfield. For extracting compiler options, the argument list is handled like the compiler would readargv. I believe this will be easier to maintain in the future.