Calendar template accessibility improvements #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
an icon isn't enough for a lot of screenreaders to infer what an action does so introduced captions for screenreaders to the table header previous/next buttons. included internationalisation support taking the locale code from moment. tests to exercise the text across various languages/datepicker types
| I just had a brief scan of this, and it looks great! Thanks! Where did you get the translations? The Chinese is correct so I know it wasn't Google translate. =) |
| I'm not seeing any changes to the scss files in this PR - are those changes no longer needed? |
| Good stuff! The translations came from a pagination gem which I've used before. Figured better to use something with open contributions rather than risking a translation service. When I ran the tests/demo on a clean develop branch, the style for the class was already included (it's a basic Bootstrap one), so I figured it could be missed out. |
dalelotts added a commit that referenced this pull request Nov 20, 2015
Add hidden text to the left and right arrows so that screen readers can use it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
An icon isn't enough for a lot of screenreaders to infer what an action does so introduced captions for screenreaders to the table header previous/next buttons. Included internationalisation support taking the locale code from Moment.
Tests to exercise the text across various languages/datepicker types.