Skip to content

Daan fixes #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Daandelange wants to merge 2 commits into from
Closed

Daan fixes #16

Daandelange wants to merge 2 commits into from

Conversation

@Daandelange
Copy link
Collaborator

@Daandelange Daandelange commented Dec 9, 2024

A couple of crash fixes that were needed to run Mosaic. ;)

I finally got some time to review your changes to the node canvas, this should be way more stable, I was getting lots of imgui asserts (in debug builds only).
It also fixes ImguiFileBrowser but I didn't check if the author updated the lib.
@d3cod3
Copy link
Owner

d3cod3 commented Dec 10, 2024

Thanks Daan, same as for the Mosaic PR

please close this and re-make the same PR to ofxVisualProgramming 0.7.0-pre-release branch.

I'll test this on linux asap

More thanks!
@d3cod3
Copy link
Owner

d3cod3 commented Dec 10, 2024 •
edited
Loading

Or don't worry about redoing the PR, i've seen the changes, no problem, i can add them manually, it's faster
@d3cod3
Copy link
Owner

d3cod3 commented Dec 10, 2024

Already committed to 0.7.0-pre-release branch

thanks again!
@d3cod3 d3cod3 closed this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@Daandelange @d3cod3