Skip to content

(testing): Fix PHPUnit deprecations #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2021
Merged

(testing): Fix PHPUnit deprecations #19

merged 1 commit into from
Jan 27, 2021

Conversation

@Tjoosten
Copy link
Contributor

@Tjoosten Tjoosten commented Jan 26, 2021

After running phpunit for this package i bumped into the following.

PHPUnit 9.5.1 by Sebastian Bergmann and contributors. ..........W.................... 31 / 31 (100%) Time: 00:00.861, Memory: 20.00 MB There was 1 warning: 1) Czim\Repository\Test\BaseRepositoryTest::it_takes_criteria_and_handles_basic_criteria_manipulation assertRegExp() is deprecated and will be removed in PHPUnit 10. Refactor your code to use assertMatchesRegularExpression() instead. assertNotRegExp() is deprecated and will be removed in PHPUnit 10. Refactor your code to use assertDoesNotMatchRegularExpression() instead. WARNINGS! Tests: 31, Assertions: 112, Warnings: 1.

So i replaced all the ->assertNotRegExp() methods to ``->assertMatchesRegularExpression() and->assertNotRegExp()` to `-> assertMatchesRegularExpression()`
(testing): Fix PHPUnit deprecations
9ab40c9 
->assertRegExp(); is deprecated and will be removed in PHPUnit 10 ->assertNotRegExp(); is deprecated and will be removed in PHPUnit 10 So i converted the assertRexExp(); to assertMatchesRegularExpressions(); And assetNotRegExp() with assertDoesNotMatchRegularExpression() [SIGNED OFF]: Tim Joosten
@czim
Copy link
Owner

czim commented Jan 27, 2021

Thanks!
@czim czim merged commit 92d4d57 into czim:master Jan 27, 2021
@Tjoosten Tjoosten deleted the phpunit-deprecations branch January 28, 2021 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@Tjoosten @czim