Skip to content

Conversation

@Tjoosten
Copy link
Contributor

Updated some package dependencies for Support Laravel 8. Also i bumped the supported php version and added php 8.

Because following the following page. (https://www.php.net/supported-versions.php)
php 7.2 is not actively maintained anymore

@czim
Copy link
Owner

czim commented Dec 19, 2020

Thanks for your work. I agree with the version bump, but not with increasing the minimum required version. Though it is not recommended to use older Laravel & PHP versions, this package still works with them. I'll make the changes, but keep the lower limit as it currently is.

If you can make the php requirement ^7.2|^8.0 and the illuminate requirements ^6|^7|^8, that'd be great.

@Tjoosten
Copy link
Contributor Author

Hey Czim,

Thanks for your response. I will make the changes somewhere next week. Ill keep you posted

@Tjoosten
Copy link
Contributor Author

hey @czim

I lowered the version bump. Can u review and tell me if something more is needed.

@czim
Copy link
Owner

czim commented Dec 21, 2020

Looks great, thanks a lot!

@czim czim merged commit 26029e1 into czim:master Dec 21, 2020
@Tjoosten Tjoosten mentioned this pull request Dec 21, 2020
@Tjoosten Tjoosten deleted the bump-php branch December 21, 2020 19:02
@Tjoosten Tjoosten mentioned this pull request Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants