fix: set Next.js pages to load from /pages folder

[bahmutov]

• closes Next.js plugin is treating the entire projectRoot as pages #513
• added example component from Next.js: Verify that non-page components are incorrectly treated as pages #517

[larrifax]

Is projectRoot always the path to the directory containing cypress.json? In that case, a directory structure like the following would make the pagesDir refer to a incorrect directory:

./ ├─ src/ │ ├─ pages/ │ ├─ components/ ├─ cypress/ ├─ cypress.json ├─ package.json 

It may well be that it doesn't have any adverse affects though. And if so, only for tests written against page-components.

[bahmutov]

Question - how does "regular" Next.js know what folder to use: /pages or /src/pages?

[bahmutov]

I will land this fix (since it can solve at least some problems) and we can look at /pages vs /src/pages separately

[larrifax]

Question - how does "regular" Next.js know what folder to use: /pages or /src/pages?

Good question! Hadn't thought about that. Seems like they look for both paths, ref. https://nextjs.org/docs/advanced-features/src-directory

[bahmutov]

🎉 This PR is included in version 4.16.6 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[bahmutov]

Ha, @larrifax I think we could change this line to

const rootPages = path.join(config.projectRoot, 'pages') const srcPages = path.join(config.projectRoot, 'src', 'pages') pagesDir: fs.existsSync(rootPages) ? rootPages : srcPages