This repository was archived by the owner on Mar 5, 2022. It is now read-only.
Addons for #37: Module cache, more cy.get aliases, typings for TS #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
added 15 commits January 22, 2019 10:52
| @RcKeller this is an incredible contribution, would you like to join as a collaborator? |
bahmutov reviewed Feb 18, 2019
| @example cy.get(<Component />) | ||
| @example cy.get(Component) | ||
| **/ | ||
| Cypress.Commands.overwrite('get', (originalFn, selector, options) => { |
bahmutov reviewed Feb 18, 2019
| @@ -0,0 +1,16 @@ | |||
| declare namespace Cypress { | |||
There was a problem hiding this comment.
super, adding types for new cy methods
bahmutov reviewed Feb 18, 2019
| */ | ||
| before(() => { | ||
| Cypress.modules = [] | ||
| cy.log('Initializing UMD module cache') |
There was a problem hiding this comment.
interesting solution here, really interesting
Gladly - thank you! |
dmtrKovalenko pushed a commit to cypress-io/cypress that referenced this pull request Oct 1, 2020
…ypress-react-unit-test#45) * Fixed users spec - had race condition * Drafted cypress commands * Lib functions as commands. Use node_modules for loading React * Switch over to using cy.mount. Docs updated * Version bumping incl. babel@7 * Added error boundaries - good example component * Line about err boundary component * Only load modules once. Refactoring * Bookmarking this for now * modules fixture * Use react displaynames * Overrode cy.get() to support JSX * Updated README.md * Add typings
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Based on feedback from #37 (thanks for merging!)
modules.jsonfixture to specify modules & their load order.beforeAllhook and kept in memory.cy.get()to support three different selectors:@DisplayName,<JSX />or theReact.Componentitself. Did this in a way so that you didn't have to load React into memory for typechecking component instances.