Implement the basic installation helper #433
Conversation
| how do I run this? |
init/init.ts Outdated
| import NextTemplate from './templates/next' | ||
| import chalk from 'chalk' | ||
| | ||
| const templates: Record<string, Template> = { |
There was a problem hiding this comment.
if everything fails or in general we should give this URL for users to open for anything else https://github.com/bahmutov/cypress-react-unit-test#install
|
|
| can't we transpile it the same way we transpile code already? into something like |
| We transpile it this way. You can run |
| Yra, the CI is green |
There was a problem hiding this comment.
- Add some kind of greeting line explaining the tool running, something like
cypress-react-unit-test@version adding component testing wizard - when failing to find something we need to put link to the installation section of the README, otherwise the user has not idea what just happened
$ node ../cypress-react-unit-test/bin/init.js It looks like you did not install cypress. Can not find cypress.json in this or parent directories. - we need to add this wizard to the README and push the current installation instructions into the recipes
- checked if works for react-scripts, it works nicely
- don't we need executable permission on bin/init.js file?
$ ls -la bin total 48 drwxr-xr-x 8 gleb staff 256 Sep 23 08:38 . drwxr-xr-x 34 gleb staff 1088 Sep 23 08:38 .. -rw-r--r-- 1 gleb staff 77 Sep 23 08:38 Template.js -rw-r--r-- 1 gleb staff 2249 Sep 23 08:38 findPackageJson.js -rw-r--r-- 1 gleb staff 7686 Sep 23 08:38 init.js drwxr-xr-x 8 gleb staff 256 Sep 23 08:38 templates -rw-r--r-- 1 gleb staff 1311 Sep 23 08:38 utils.js -rw-r--r-- 1 gleb staff 203 Sep 23 08:38 versions.js | Thanks for review!
I saw your previous comment, and added a link to the https://github.com/bahmutov/cypress-react-unit-test/blob/main/docs/recipes.md because the #install section is only adding info about |
| Ok I got this - we want the links to be shorter right. So I say we need to add to the README a section about the Then the link we can show from the CLI wizard could be https://github.com/bahmutov/cypress-react-unit-test#init (README anchors are working like https://github.com/bahmutov/cypress-react-unit-test#install) and in that section we can provide more info, explain things, link to the recipes. I think shorter links are much better |
| replace({ 'process.env.NODE_ENV': JSON.stringify('development') }), | ||
| ``` | ||
| | ||
| See [examples/rollup](examples/rollup) folder for full example. |
| } | ||
| | ||
| type FindPackageJsonResult = | ||
| | { |
There was a problem hiding this comment.
haha, we don't need no monads
| anything remaining for this most excellent PR? |
| Review from Jess ;) |
Co-authored-by: Jessica Sachs <jess@jessicasachs.io>
Co-authored-by: Jessica Sachs <jess@jessicasachs.io>
| 🎉 This PR is included in version 4.15.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
TODO