Skip to content

🎨 Implement Material You #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

🎨 Implement Material You #56

wants to merge 5 commits into from

Conversation

kabirnayeem99
Copy link

native_alpha_1
native_alpha_2
native_alpha_3
cylonid
cylonid reviewed Apr 27, 2022
View reviewed changes
app/src/main/AndroidManifest.xml

<!--Placeholder-->
<activity
android:name=".__WebViewActivity_0"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are leftovers of an unsuccessfull build. They shouldn't be commited.
@cylonid
Copy link
Owner

cylonid commented Apr 27, 2022

Thanks for your PR. I think this can make it into the new release.

A few things:

  • The spaces between the switches seem overly large, probably the new Switch elements have their own margin-bottom. Therefore, you could try to remove the android:divider the respective LinearLayout as it is not necessary any more.
  • The changes in AndroidManifest shouldn't be commited. See https://github.com/cylonid/NativeAlphaForAndroid/pull/56/files#r860246469
  • I'd prefer the font color of the floating button to be white as it was before (and still is for all other buttons)
@kabirnayeem99
Copy link
Author

Thank you for your response. I will make those changes and will push it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@kabirnayeem99 @cylonid @singhdilveer1