Move peer dependencies under "peerDependencies" key in package.json #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor Author
| I wanted to open another PR for allowing minor release differences in React as a peer dependency, otherwise I can't use React hooks with cyclejs/react (without react duplication in the bundle), but then I realized that git updates this existing PR, so it became a mixed bag. Update: I realized that NPM just warns about peer dependencies, so I can probably use any react version. I just need the peer dependency commit to be merged. Maybe I can revert the wildcard commit if it raises concerns. |
Member
| @sarimarton Thanks, I now agree with you about peerDependencies |
Contributor Author
| @staltz Many thanks, we're almost there. Turns out, |
staltz pushed a commit to cyclejs/react-dom that referenced this pull request Jul 14, 2019
After merging cyclejs/react#5, npm started to create `node_modules/@cycle/react-dom/node_modules/@cycle`, because cyclejs/react-dom currently depends on cyclejs/react-dom v2.1.0, which in turns depends on React 16.5.2... This PR is for fixing the same issue - avoid nested npm installs of peer dependencies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is a PR to mitigate the issue described in #2