[!] rewrite with consolidated sync package #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
- Consolidated all PostgreSQL operations from internal/db into internal/sync/postgresql.go - Consolidated all etcd operations from internal/etcd into internal/sync/etcd.go - Replaced COPY with INSERT ON CONFLICT using pgx.Batch for better upsert handling - Added SendBatch method to PgxIface interface for batch operations - Moved all types, connection functions, and retry logic - All build tests passing Tasks completed: T009-T022 (PostgreSQL and etcd consolidation phases)
- Updated all import statements to use internal/sync package - Fixed NULL value handling for tombstones in database operations - Updated integration tests to work with consolidated package - All tests now passing (100% success rate) - Maintained identical functionality while simplifying architecture Completed tasks: T023 (import updates) + critical bug fixes Remaining tasks: T024-T047 (cleanup, validation, optimization)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.