- Notifications
You must be signed in to change notification settings - Fork 159
fix: add name to devdocs-network in docker-compose.yml #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Summary by CodeRabbit
WalkthroughThe update introduces an explicit network name declaration in the Changes
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
docker/compose/docker-compose.yml
(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.35.1)
docker/compose/docker-compose.yml
[error] 80-80: no new line character at the end of file
(new-line-at-end-of-file)
🔇 Additional comments (1)
docker/compose/docker-compose.yml (1)
79-80
: Explicit Network Name ConfigurationThe explicit definition of
name: devdocs-network
alongside the existingdriver: bridge
ensures that Docker Compose creates the network with the expected name. This directly addresses the naming discrepancy issue and allows the commanddocker network inspect devdocs-network
to work as intended.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 80-80: no new line character at the end of file
(new-line-at-end-of-file)
Fix Docker Network Name for Consistent Inspection
Issue
When attempting to inspect the Docker network using
docker network inspect devdocs-network
, the command failed because the actual network name created by Docker Compose wasdevdocs_devdocs-network
.Root Cause
This discrepancy occurs because Docker Compose follows a standard naming convention for resources it creates:
[project name]_[resource name]
. In our original configuration, we defined the network asdevdocs-network
:However, Docker Compose automatically prefixed it with the project name, resulting in the actual network name being
devdocs_devdocs-network
.Solution
This PR explicitly sets the network name using the
name
property in the network definition:With this change, the network will be created with exactly the name we expect, allowing
docker network inspect devdocs-network
to work as intended.